boot: one hand-off contract, defined once
Groundwork for the unified loader: before the two paths can share code, they have to agree on what they are producing, and until now they only agreed by coincidence. Every field of the loader/kernel hand-off was #defined in whichever file happened to need it -- kernel/core/main.c, kernel/dev/vga.c, kernel/arch/x86_64/e820.c, boot/bios/cdboot.S, boot/bios/stage2main.c and boot/uefi/main.c, six copies of the same addresses. schboot.h existed for exactly this and held only the entry magic and the RSDP slot, with a comment describing the rest of the block it did not define. The whole block lives there now: the VBE info fields, the verbose and media flags (with the real-mode segment:offset spelling cdboot.S needs), the e820 count, map and cap, and the RSDP. Every one of those files includes it instead of restating it. This is not a tidy-up. It is the same hazard as defining the entry magic twice, only quieter -- nothing breaks until one copy moves, and the two loaders diverging is precisely what produced the EFER.SCE and RSDP bugs, where a fix on one path silently did not exist on the other. Verified on both firmwares: BIOS boots to schinit with the same e820, ACPI and VGA lines as before; UEFI reaches cpu0 with 1018 MB in 7 regions and its own 1280x800 mode. `make iso` still builds. bootcheck 108 [ok]. Next: the loaders become starters that gather firmware-specific facts and hand to one common stage. That needs the BIOS side to climb to long mode first, since common code can only be compiled for one CPU mode -- which is the risky part, and is why the contract went first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
b34779111a
commit
0500e4382d
7 changed files with 89 additions and 56 deletions
|
|
@ -40,23 +40,23 @@ vga_set_bg(uint32 color)
|
|||
}
|
||||
|
||||
// Written by boot/bios/stage2.S's VBE call and read by boot/bios/stage2main.c under
|
||||
// the same name (VBE_INFO_ADDR) — not 0x9000, since stage2's own code now
|
||||
// the same name (SCHBOOT_VBE_INFO) — not 0x9000, since stage2's own code now
|
||||
// runs up to nearly 0x9000 once the boot-menu/progress-bar logic is
|
||||
// included, which would otherwise clobber a mode info block placed there.
|
||||
#define VBE_INFO_ADDR 0x30000
|
||||
#include "schboot.h" /* the hand-off block */
|
||||
|
||||
void
|
||||
vga_init(uint64 phys_addr) {
|
||||
if (phys_addr == 0) {
|
||||
phys_addr = *(uint32*)(P2V(VBE_INFO_ADDR) + 40);
|
||||
phys_addr = *(uint32*)(P2V(SCHBOOT_VBE_LFB));
|
||||
}
|
||||
vga_mem = (volatile uchar*)P2V(phys_addr);
|
||||
vga_phys = phys_addr;
|
||||
|
||||
vga_stride = *(ushort*)(P2V(VBE_INFO_ADDR) + 16);
|
||||
vga_width = *(ushort*)(P2V(VBE_INFO_ADDR) + 18);
|
||||
vga_height = *(ushort*)(P2V(VBE_INFO_ADDR) + 20);
|
||||
vga_bpp = *(uchar*)(P2V(VBE_INFO_ADDR) + 25);
|
||||
vga_stride = *(ushort*)(P2V(SCHBOOT_VBE_STRIDE));
|
||||
vga_width = *(ushort*)(P2V(SCHBOOT_VBE_WIDTH));
|
||||
vga_height = *(ushort*)(P2V(SCHBOOT_VBE_HEIGHT));
|
||||
vga_bpp = *(uchar*)(P2V(SCHBOOT_VBE_BPP));
|
||||
|
||||
if (vga_width == 0) vga_width = 800;
|
||||
if (vga_height == 0) vga_height = 600;
|
||||
|
|
|
|||
Loading…
Reference in a new issue