ldls: a second driver, and everything it found
e1000 -- Linux's, unmodified -- probes, opens, gets an address by DHCP and
carries ping traffic in a SchOS process. The kernel was driving that NIC and
gave it up, which makes it the first real handover as well as the second
driver.
None of what it needed was a missing feature. Every one was a call that
succeeded, returned zero and did nothing:
_find_next_bit "bit 0 is set" -- for_each_cpu never ended
netif_carrier_off carrier already up -- TCTL.EN never set
__x86_indirect_thunk_r8 the jump discarded -- 255 rx buffers, none made
dma_map_page_attrs bus address 0 -- NIC aimed at physical 0
so the rule from memcpy is now general: a stub returning zero is unsafe
wherever zero is a meaningful answer.
The loader grew ko_fixup_percpu(). The stack guard turned out to be one
per-CPU variable among several; `current` cannot be defused because the driver
dereferences it. Taking the %gs off instead leaves the same opcode reading the
same width from storage the host supplies -- a per-CPU variable in a
single-threaded host is just a variable. Eight bytes become seven and a nop,
and the displacement is not always last, so there is now just enough of an x86
decoder in ko.c to know how long the instruction is.
ldls/kpi/thunk.c is fifteen lines of assembly and the highest-value file here:
retpolines are control flow, and a stub cannot stand in for a jump.
The kernel side:
- ioperm.c, the TSS I/O permission bitmap. A driver's outl is an instruction,
not a call, and e1000's reset path picks it deliberately. IOPL=3 would hand
over the PIC and the disk with it, so it is per-port. Writing it found that
the I/O map base had been written at offset 64 rather than 102, leaving the
CPU checking ports 0-831 against the TSS's own RSP0.
- claim masks the device's IRQ line: 450,000 a second, otherwise.
- net_detach(), the missing half of net_attach_late(). An interface left in
the stack keeps its route and sends every frame to a driver that refuses
it, which looks exactly like a userspace driver that does not work.
- e1000_release() gives up the interface, not just the hardware.
8139too still passes 4/4; ldls-check still passes 27; four CPUs, no panic.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQ7Qx8E1q1M1bbCq8QLHS2
This commit is contained in:
parent
f38eb8a7fd
commit
071499a378
26 changed files with 2009 additions and 46 deletions
|
|
@ -20,6 +20,11 @@
|
|||
#include "pciuser.h"
|
||||
#include "kpi.h"
|
||||
|
||||
// The PCI resource flag bits, which are ABI between the kernel and every
|
||||
// driver written against it. Not layout, so BTF does not carry them.
|
||||
#define LDLS_IORESOURCE_IO 0x00000100
|
||||
#define LDLS_IORESOURCE_MEM 0x00000200
|
||||
|
||||
// The device is claimed by the host before the driver runs, because claiming
|
||||
// is what enables memory space and bus mastering -- and a BAR read before that
|
||||
// can legitimately be zero. So by the time a driver calls this, it has already
|
||||
|
|
@ -145,6 +150,57 @@ kpi_pci_iomap(void *pdev, int bar, unsigned long max)
|
|||
return p;
|
||||
}
|
||||
|
||||
// pci_ioremap_bar(pdev, bar) -- the same thing as pci_iomap with no cap. A
|
||||
// second spelling, which is the sort of thing a second driver turns up.
|
||||
void *
|
||||
kpi_pci_ioremap_bar(void *pdev, int bar)
|
||||
{
|
||||
return kpi_pci_iomap(pdev, bar, 0);
|
||||
}
|
||||
|
||||
// pci_select_bars(pdev, flags) -- which BARs match a resource kind.
|
||||
//
|
||||
// A driver asks this before requesting regions, so the answer decides which
|
||||
// BARs it thinks exist. Reporting one that is not there gets it refused later;
|
||||
// omitting one it needs gets it to give up here.
|
||||
int
|
||||
kpi_pci_select_bars(void *pdev, unsigned long flags)
|
||||
{
|
||||
int bars = 0, b;
|
||||
|
||||
(void)pdev;
|
||||
for (b = 0; b < 6; b++) {
|
||||
if (!kpi.bar_base[b])
|
||||
continue;
|
||||
if ((kpi.bar_flags[b] & PCIUSER_BAR_IO) && (flags & LDLS_IORESOURCE_IO))
|
||||
bars |= 1 << b;
|
||||
if ((kpi.bar_flags[b] & PCIUSER_BAR_MMIO) && (flags & LDLS_IORESOURCE_MEM))
|
||||
bars |= 1 << b;
|
||||
}
|
||||
return bars;
|
||||
}
|
||||
|
||||
int
|
||||
kpi_pci_request_selected_regions(void *pdev, int bars, const char *name)
|
||||
{
|
||||
(void)pdev; (void)bars; (void)name;
|
||||
return 0; // nobody to arbitrate with; see above
|
||||
}
|
||||
|
||||
void
|
||||
kpi_pci_release_selected_regions(void *pdev, int bars)
|
||||
{
|
||||
(void)pdev; (void)bars;
|
||||
}
|
||||
|
||||
// Saving and restoring config space is what a driver does around a reset it
|
||||
// expects to clear the BARs. LDLS never resets the device at that level and
|
||||
// has no config write to restore with, so there is nothing to save -- and
|
||||
// saying so by succeeding is right, because a driver that cannot save state
|
||||
// refuses to probe at all.
|
||||
int kpi_pci_save_state(void *pdev) { (void)pdev; return 0; }
|
||||
void kpi_pci_restore_state(void *pdev) { (void)pdev; }
|
||||
|
||||
void
|
||||
kpi_pci_iounmap(void *pdev, void *addr)
|
||||
{
|
||||
|
|
|
|||
Loading…
Reference in a new issue