schfs: the allocation map can be given back, so unmount stops leaking it

Started as "fix the ASAN leak in schfs_objtest" and the test turned out to be
the messenger. The allocation map was taken through a palloc callback and there
was no way to return it: no schfs_space_release, and a comment in
schfs_space_init reading "caller frees what was taken" for an API the caller
did not have.

Three separate leaks from that one gap:

  * The kernel leaked the entire map on every unmount -- up to 2 MB, at 8 KiB
    per GiB of volume -- because kmount_unmount flushed, cleared `mounted` and
    walked away. This is the one that matters; the others are test-only.
  * schfs_space_init stranded a page on its own error path. npages was raised
    only after *both* of a pair of allocations succeeded, so a failure on the
    second left the first outside the count -- unreachable to any cleanup that
    could later exist.
  * schfs_objtest leaked 2121728 bytes in 518 allocations, which is what made
    the whole SchFS suite exit non-zero regardless of its assertions.

The map now carries its own pfree rather than taking one at release time, so it
can only ever be freed by the allocator that filled it -- the kernel's pages
come from kalloc and a host tool's from calloc, and the two are not
interchangeable. schfs_vol_open and schfs_vol_format release any map the volume
is already holding before building another, which is what stops a re-open
leaking; struct schfs_vol must therefore be zeroed before first use, and the
header now says so.

The test's own leak was the last one found and the simplest: it does
memset(&VOL, 0, sizeof(VOL)) before reopening, which wiped the map's pointers
before vol_open could release them. Eight of those, each now releasing first.

schfs_objtest asserts the balance -- 520 pages taken, 520 given back -- because
a suite that leaks cannot detect a leak: the filesystem's own allocations would
arrive as noise inside the harness's. The next one fails the run instead.

make schfs-check now exits 0. The 31 UBSAN misalignment reports are still
there and are still a Gate 0 item.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQ7Qx8E1q1M1bbCq8QLHS2

kernel/fs/schfs/space.c

@@ -126,11 +126,26 @@ schfs_space_reset(struct schfs_space *s, uint64_t nblocks)
         bit_set(s->inuse, b);
 }
 
+void
+schfs_space_release(struct schfs_space *s)
+{
+    if (s->pfree) {
+        for (int i = 0; i < s->npages; i++) {
+            if (s->inuse[i]) s->pfree(s->inuse[i]);
+            if (s->pend[i])  s->pfree(s->pend[i]);
+        }
+    }
+    // Zeroed rather than merely emptied, so calling this twice is harmless and
+    // a released map cannot be mistaken for a sized one.
+    memset(s, 0, sizeof(*s));
+}
+
 int
 schfs_space_init(struct schfs_space *s, uint64_t nblocks,
-                 void *(*palloc)(void))
+                 void *(*palloc)(void), void (*pfree)(void *))
 {
     memset(s, 0, sizeof(*s));
+    s->pfree = pfree;
 
     if (nblocks <= SCHFS_FIRST_BLOCK)
         return -3;
@@ -141,16 +156,26 @@ schfs_space_init(struct schfs_space *s, uint64_t nblocks,
                     / SCHFS_SPACE_BITS_PER_PAGE;
 
     for (uint64_t i = 0; i < npages; i++) {
+        // npages is raised as soon as inuse[i] is ours, not after both pages
+        // are. It used to be raised after, which meant a failure on the second
+        // allocation left the first one owned by nobody: outside the count, so
+        // unreachable to any cleanup, and never freed. The comment here said
+        // "caller frees what was taken" and there was nothing the caller could
+        // call.
         void *p = palloc();
-        if (p == 0)
-            return -5;               /* caller frees what was taken */
+        if (p == 0) {
+            schfs_space_release(s);
+            return -5;
+        }
         s->inuse[i] = (uint64_t *)p;
+        s->npages   = (int)(i + 1);
 
         p = palloc();
-        if (p == 0)
+        if (p == 0) {
+            schfs_space_release(s);
             return -5;
+        }
         s->pend[i] = (uint64_t *)p;
-        s->npages = (int)(i + 1);
     }
 
     schfs_space_reset(s, nblocks);