errno: -1 is EPERM, and four places were saying it by accident

Ctrl-C killed the shell. consoleread() breaks off the read in progress when
SIGINT arrives and returned -1 to do it -- and -1 is -EPERM by the time it
reaches a program, so every program that handles SIGINT by carrying on saw a
permanent error instead of an interrupted call:

    zsh: error on TTY read: operation not permitted
    schinitd: restarting os.schos.console-shell

and the next Ctrl-C did it to the replacement. EINTR now, which is what a
signal-interrupted read is required to give. Verified: Ctrl-C an interruptible
command, shell survives, zero restarts.

Same mistake, same file family: link, unlink, rename and renameat returned -1
on every error path. Callers branch on errno -- `if (unlink(p) < 0 && errno !=
ENOENT)` is the standard shape, and against EPERM it always complains -- which
is why zsh reported failures for things that had worked. They return ENOENT,
EEXIST, EXDEV, EISDIR, ENOTEMPTY and EFAULT now. About ninety other `return -1`s
remain in sys_fs.c; these four are done because these four were what a program
tripped over. /dev/mem's unknown minors return ENODEV rather than -1 too.

/dev/urandom was a linear congruential generator seeded with a **constant**, so
every boot produced the same bytes in the same order -- not weak, the same. A
key, a nonce, a temporary filename: shared with every SchOS machine that had
ever run. Seeded at boot from RDRAND where the CPU has it, from the cycle
counter and the wall clock where it does not, and re-stirred per byte. Still an
LCG and still not a CSPRNG; what changed is the part that was dangerous rather
than merely poor.

**Not fixed, and recorded as such:** rename() still will not replace an existing
target, so zsh's history save fails on every exit after the first. An attempt to
unlink the target first was reverted -- the directory is an HTree, dirunlink
followed by dirlink of the same name did not behave, and it panicked in
filewrite with the old file already gone. Losing both files is worse than
refusing, so it refuses until the HTree's slot reuse is understood.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQ7Qx8E1q1M1bbCq8QLHS2
This commit is contained in:
Nexoniarz 2026-09-14 22:12:28 +02:00
commit 75ccf9841c
11 changed files with 330 additions and 42 deletions

View file

@ -10,6 +10,7 @@
#include "irq.h"
#include "param.h"
#include "traps.h"
#include "errno.h"
#include "spinlock.h"
#include "sleeplock.h"
#include "fs.h"
@ -611,11 +612,27 @@ consoleread(struct inode *ip, uint64 off, char *dst, int n)
ilock(ip);
return 0; // end of input
}
// Interrupted, not forbidden.
//
// This returned -1, and -1 is -EPERM. A read broken off by Ctrl-C
// therefore reached userspace as "operation not permitted", which is a
// permanent error -- so every program that handles SIGINT by carrying on
// saw a fatal one instead and exited:
//
// zsh: error on TTY read: operation not permitted
// schinitd: restarting os.schos.console-shell
//
// and then did it again, because the next Ctrl-C did the same thing. A
// shell that cannot survive Ctrl-C is a shell nobody can use.
//
// EINTR is the answer a signal-interrupted read is required to give, and
// the whole convention -- retry, or return to the caller -- is built on
// getting it rather than something else.
if (myproc()->killed || v->in.abort_read) {
v->in.abort_read = 0;
release(&input_lock);
ilock(ip);
return -1;
return -EINTR;
}
sleep(&v->in.r, &input_lock);
}