hybrid: the driver is killed, and the driver comes back
H2 of docs/plan/hybrid.md -- the milestone the plan itself calls the one
that proves the whole idea, and the one that cannot be skipped.
# cat /proc/schinit
1 4 11 os.schos.vgpud
# kill 4
schinitd: restarting os.schos.vgpud
vgpud: claimed
vgpud: pid 8 drew a test pattern from userspace
The test pattern ends in a twelve-block tally of the drawing process's
pid, because a second run that redraws an identical picture is
indistinguishable from a first run that never stopped. Read off the
virtio-gpu scanout across four generations it says 4, 8, 10, 12, and the
DMA arena hands back the same physical address every time.
What it took:
* A halt the kernel can apply to a device it does not understand.
Clearing PCI_CMD_BUS_MASTER is the only one there is, and it has to
happen before the DMA goes back to the arena -- a dead driver's device
keeps reading a framebuffer the kernel is about to give to somebody
else. Claim sets the bit, release clears it; pcitest shows it in a bm
column, with a third state so a failed read is never printed as off.
* A refusal. vgpu_release() asks vga_fb_restore() whether there is a
framebuffer to put the console back on, and declines to hand over the
device if there is not. The rule that the kernel keeps a minimal
driver for everything on the path to a shell is worth writing down
only if something enforces it.
* The DMA arena not being owned by two allocators at once. This is the
bug that stopped H2: freevm() frees every mapped page below PHYSTOP
and the arena is the top 16 MB of exactly that range, so a DMA block
mapped into a driver went onto the page allocator's free list when the
driver died, while pciuser_release_all() handed the same pages back to
the arena. The restarted vgpud asked for its framebuffer, got pages
kalloc() had already given out -- including its own page tables -- and
dma_alloc()'s zeroing wiped them, so it died inside the ioctl on the
return from a syscall whose stack had stopped existing. do_dma() now
records a VMA with no_free set, the way shared memory does.
* One exit status. KeepAlive must restart a driver that crashed and must
not restart one that has looked at the machine and found its device
absent: on hardware with no virtio-gpu that was fifteen spawns in
forty-five seconds, each printing a line to the console, for ever.
SCHINIT_EXIT_NORESTART is 78, sysexits.h's EX_CONFIG. It is not a new
manifest key -- the wait status has always travelled from PID 1 to the
supervisor, and note_exit() simply stopped discarding it.
The milestone's third clause, "the compositor reattaches", is not done
and is not claimed: there is no compositor running. That is recorded in
the plan as a Schcom milestone rather than counted here.
Closes the register row "A released PCI device" in docs/plan/1.0.md.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQ7Qx8E1q1M1bbCq8QLHS2
This commit is contained in:
parent
c0ed23cc56
commit
d1f50c4da3
15 changed files with 442 additions and 40 deletions
|
|
@ -172,6 +172,7 @@ uint16 pci_read16(uint8, uint8, uint8, uint8);
|
|||
uint8 pci_read8(uint8, uint8, uint8, uint8);
|
||||
void pci_write32(uint8, uint8, uint8, uint8, uint32);
|
||||
void pci_enable(struct pci_dev *, uint16 bits);
|
||||
void pci_disable(struct pci_dev *, uint16 bits);
|
||||
uint8 pci_find_cap(struct pci_dev *, uint8 id);
|
||||
int pci_msi_enable(struct pci_dev *, int vector, int cpu);
|
||||
int pci_count(void);
|
||||
|
|
@ -611,7 +612,7 @@ void platform_register_devices(uint64 fb_addr);
|
|||
// from registry.c; everything else draws through include/gfx.h.
|
||||
void vga_fb_init(uint64 phys_addr);
|
||||
uint64 vga_fb_phys(void);
|
||||
void vga_fb_restore(void);
|
||||
int vga_fb_restore(void); // 0 = there is no fallback
|
||||
uint64 vga_fb_size(void);
|
||||
|
||||
void e820_init(void);
|
||||
|
|
|
|||
|
|
@ -50,6 +50,26 @@
|
|||
#define SCHINIT_EXITED 130 // struct schinit_reply -- a child has been reaped
|
||||
#define SCHINIT_PING 131 // struct schinit_hello -- answer within the deadline
|
||||
|
||||
// Exit statuses a job can use to tell the supervisor something.
|
||||
//
|
||||
// KeepAlive restarts a job that crashed or was killed, which is the whole
|
||||
// point of it for a driver. It must not restart one that has looked at the
|
||||
// machine and reported there is nothing here for it to do: a driver whose
|
||||
// device is absent fails identically every time, and a supervisor that tries
|
||||
// anyway spends the rest of the uptime doing so -- 15 spawns in 45 seconds,
|
||||
// on hardware with no virtio-gpu, each one printing a line to the console.
|
||||
//
|
||||
// 78 is sysexits.h's EX_CONFIG, "something was found in an unconfigured or
|
||||
// misconfigured state", which is exactly what a driver with no device has
|
||||
// found. Borrowed rather than invented, so a program written against any
|
||||
// other Unix already means the right thing by it.
|
||||
//
|
||||
// Note what this is *not*: it is not a new manifest key and not a new policy
|
||||
// knob. The wait status has always travelled from PID 1 to the supervisor in
|
||||
// struct schinit_reply, and note_exit() has always thrown it away. This is
|
||||
// the other half of a thing that was already built.
|
||||
#define SCHINIT_EXIT_NORESTART 78
|
||||
|
||||
// The heartbeat.
|
||||
//
|
||||
// docs/architecture/init.md, "The heartbeat" -- the failure the two-init scheme
|
||||
|
|
|
|||
Loading…
Reference in a new issue