SchOS/kernel/net/lwip/netif_eth.c
Nexoniarz 20cc673a41 net: a network *class*, so the stack stops knowing what an e1000 is
The TCP/IP stack reached straight into the first driver anyone wrote.
net.c called e1000_present(), the lwIP glue was named netif_e1000.c and
called e1000_transmit(), and include/defs.h declared the driver's
internals to the whole kernel. The second NIC driver would therefore
have arrived with a near-identical copy of the glue file and a patch to
the protocol stack, which is the arrangement include/device.h was
written to prevent -- the e1000 even said so, with `.ops = 0, // no
class vtable yet; there is no net class`.

There is now. A driver publishes a struct netdev_ops -- transmit,
receive, mac, link_up -- and is finished: it never mentions lwIP, and
nothing above it learns its name. The display class was already this
shape; this is the same shape for networking, and the two now read the
same way in kernel/dev/device.c.

What that made possible immediately:

  - One netif per bound device instead of one per driver. lwIP's glue is
    netif_eth.c, it takes a struct device, and it holds up to NETIF_MAX
    interfaces. net.c attaches every network device it finds and starts
    DHCP on each, because which interface the network answers on is not
    ours to decide.
  - /proc/netif lists all of them, one block of fields each, with the
    interface name and the driver that claimed it.
  - The ARP self-test moved from the e1000 to the class. Nothing in it
    was chip-specific, and it is the first thing anyone will want to run
    against the next driver. Still `echo n > /proc/sysrq`.
  - Private headers live with their driver: e1000.h was in include/,
    where exactly one file could use it. The driver build now adds the
    driver's own directory to the include path.

The e1000 also drives more than one card. Its probe() refused the second
outright, because there was a single static instance -- so a machine
with two of them drove one and silently ignored the other. Instances are
an array now, and the instance is hung on dev->priv by a new optional
`attached` hook that the bus calls once the device exists. probe() runs
before device_add(), so there was previously nowhere to put it; that is
the whole reason the hook exists rather than a line inside probe.

QEMU gets an explicit NIC on every target (QEMU_NET). The default device
happens to be an e1000 on this machine type today, which is exactly the
sort of thing that stays true until a QEMU release changes it and the
network stops being exercised without anyone noticing.

Verified:
  - bootcheck -Net passes, 48 [ok], no failures -- including the moved
    self-test and two new checks that /proc/netif names both the
    interface and the driver behind it, which together say the stack
    went through the class rather than through a driver it was compiled
    to know.
  - Two NICs attached by hand (-device e1000 twice, second with its own
    MAC): eth0 and eth1 both attach, each reports its own MAC in
    /proc/netif, and each gets its own DHCP lease. Before this commit
    the same machine produced one interface.
  - make schfs-check still passes in full.

One trap worth recording: moving a header broke the build for anyone
with stale .d files -- make stopped with "No rule to make target
'include/e1000.h'". CFLAGS gains -MP, which emits a phony target per
header so a moved or deleted one can never wedge the build again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-15 16:42:34 +02:00

215 lines
6.5 KiB
C

// SPDX-License-Identifier: Apache-2.0
//
// lwIP network interfaces over the netdev class.
//
// The seam, and it is deliberately driver-agnostic: everything about IP, ARP
// and TCP lives in lwIP, everything about descriptors and registers lives in a
// driver, and this file knows only that a network device can transmit a frame,
// receive a frame and state its MAC address. It was `netif_e1000.c` and called
// `e1000_transmit` directly, which meant the second NIC driver would have
// arrived with a second near-identical copy of this file. See include/netdev.h.
//
// One netif per bound interface, up to NETIF_MAX. Two NICs is an ordinary
// machine -- a laptop with Ethernet and the virtual one QEMU adds is already
// two -- and the limit exists only because a fixed array is simpler than
// allocation for something enumerated once at boot.
#include "types.h"
#include "defs.h"
#include "param.h"
#include "device.h"
#include "netdev.h"
#include "lwip/opt.h"
#include "lwip/netif.h"
#include "lwip/pbuf.h"
#include "lwip/etharp.h"
#include "lwip/ethip6.h"
#include "netif/ethernet.h"
#define ETH_MTU 1500
#define ETH_FRAMESZ 1518 // 1500 payload + 14 header + 4 FCS allowance
struct eth_if {
struct netif netif;
struct device *dev;
// Frames in and out, for /proc/netif. Counted at this seam rather than in
// the driver on purpose: a frame the driver received and this file dropped
// never reached the stack, and a counter one layer down would say it did.
uint64 rx_frames, tx_frames;
int used;
};
static struct eth_if ifs[NETIF_MAX];
static int nifs;
// One staging buffer each, not one per call: a frame is 1518 bytes and the
// kernel stack is 4096 in total, so a local of this size on a path that is
// several frames deep is exactly the overflow the kstack canary exists to
// catch. Safe as a single static because every caller holds the lwIP lock --
// which is also why one pair serves every interface.
static char txframe[ETH_FRAMESZ];
static char rxframe[ETH_FRAMESZ];
// Send one packet. lwIP hands over a pbuf chain; a driver wants one flat
// buffer, so this walks the chain into txframe.
static err_t
eth_linkoutput(struct netif *netif, struct pbuf *p)
{
struct eth_if *e = netif->state;
if (p->tot_len > sizeof(txframe))
return ERR_IF;
u16_t off = 0;
for (struct pbuf *q = p; q != NULL; q = q->next) {
if (off + q->len > sizeof(txframe))
return ERR_IF;
memmove(txframe + off, q->payload, q->len);
off += q->len;
}
// A full transmit ring is congestion, not failure. Reporting ERR_IF would
// make lwIP drop the segment and wait for a retransmission timer;
// ERR_WOULDBLOCK lets it try again, which for TCP is the difference between
// a stall of milliseconds and one of seconds.
if (netdev_transmit(e->dev, txframe, off) != 0)
return ERR_WOULDBLOCK;
e->tx_frames++;
return ERR_OK;
}
// Bring one interface up. Called by netif_add, once per device.
static err_t
eth_netif_init(struct netif *netif)
{
struct eth_if *e = netif->state;
const unsigned char *mac = netdev_mac(e->dev);
netif->name[0] = 'e';
netif->name[1] = 'n';
netif->output = etharp_output; // IP -> ARP -> linkoutput
netif->linkoutput = eth_linkoutput;
netif->mtu = ETH_MTU;
netif->hwaddr_len = 6;
for (int i = 0; i < 6; i++)
netif->hwaddr[i] = mac ? mac[i] : 0;
netif->flags = NETIF_FLAG_BROADCAST | NETIF_FLAG_ETHARP | NETIF_FLAG_LINK_UP;
return ERR_OK;
}
// Attach one network device. Returns its interface index, or -1.
//
// No address: DHCP fills that in, and an interface that came up with a
// hardcoded one would be wrong on every network but the one it was written on.
int
net_eth_attach(struct device *dev)
{
ip4_addr_t any;
if (nifs >= NETIF_MAX || dev == 0)
return -1;
struct eth_if *e = &ifs[nifs];
e->dev = dev;
e->used = 1;
IP4_ADDR(&any, 0, 0, 0, 0);
if (netif_add(&e->netif, &any, &any, &any, e,
eth_netif_init, netif_input) == NULL) {
e->used = 0;
return -1;
}
// The first one is the default route. With one interface that is the only
// possible answer; with two it is a policy decision that belongs to a
// routing table this kernel does not have yet, and picking the first is at
// least a rule rather than an accident of enumeration order.
if (nifs == 0)
netif_set_default(&e->netif);
netif_set_up(&e->netif);
if (netdev_link_up(dev))
netif_set_link_up(&e->netif);
else
netif_set_link_down(&e->netif);
return nifs++;
}
int
net_eth_count(void)
{
return nifs;
}
struct netif *
net_eth_netif(int i)
{
if (i < 0 || i >= nifs)
return 0;
return &ifs[i].netif;
}
struct device *
net_eth_device(int i)
{
if (i < 0 || i >= nifs)
return 0;
return ifs[i].dev;
}
void
net_eth_counts(int i, uint64 *rx, uint64 *tx)
{
if (i < 0 || i >= nifs) {
*rx = *tx = 0;
return;
}
*rx = ifs[i].rx_frames;
*tx = ifs[i].tx_frames;
}
// Take whatever the drivers have and push it into lwIP. Returns how many
// frames moved across all interfaces, so the caller can tell a busy poll from
// an idle one.
//
// Bounded per interface rather than draining: a receive loop with no limit
// starves everything else on a busy network, and the caller comes straight
// back anyway.
int
net_eth_poll(void)
{
int moved = 0;
for (int k = 0; k < nifs; k++) {
struct eth_if *e = &ifs[k];
for (int i = 0; i < 32; i++) {
int len = netdev_receive(e->dev, rxframe, sizeof(rxframe));
if (len <= 0)
break;
// PBUF_POOL, so this comes from lwIP's own pool rather than a heap
// it does not have. A null return means the pool is exhausted,
// which is a dropped packet -- entirely normal under load, and what
// the protocol above is designed to survive.
struct pbuf *p = pbuf_alloc(PBUF_RAW, (u16_t)len, PBUF_POOL);
if (p == NULL)
break;
pbuf_take(p, rxframe, (u16_t)len);
// netif->input is netif_input, set at netif_add: it dispatches on
// the Ethernet type. Ownership of the pbuf passes with the call,
// including when it fails, so there is nothing to free here.
if (e->netif.input(p, &e->netif) != ERR_OK)
pbuf_free(p);
e->rx_frames++;
moved++;
}
}
return moved;
}